Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

#1089 Added nil check on associated KeyPair #1099

Merged
merged 1 commit into from
Oct 16, 2023

Conversation

kavibritto
Copy link

Problem

Click here to view the issue ticket
Runtime Error: Invalid Memory Address or Nil Pointer Dereference during Fresh Install

Solution

need nil check for instance key pair name. because we are using ec2 instance with Ec2 session managers. in this case we don't have an ec2 key pair for the instance.

Changes Made

  • Added nil Check on KeyPair checking

How to Test

  • create ec2 instance without key pair
  • run the komiser and test it

Screenshots

komiser-keypair issue

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 16, 2023
@mlabouardy mlabouardy added the aws label Oct 16, 2023
@mlabouardy mlabouardy merged commit 843d4cb into tailwarden:develop Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants